-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: show error UI when plugin has empty rows
- Loading branch information
1 parent
c39ec70
commit db2f7ce
Showing
7 changed files
with
112 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import PropTypes from 'prop-types' | ||
import React from 'react' | ||
import { GenericError } from '../../assets/ErrorIcons.js' | ||
import { VisualizationError, genericErrorTitle } from '../../modules/error.js' | ||
import styles from './styles/VisualizationErrorInfo.module.css' | ||
|
||
export const VisualizationErrorInfo = ({ error }) => ( | ||
<div | ||
className={styles.errorContainer} | ||
data-test="start-screen-error-container" | ||
> | ||
{error instanceof VisualizationError ? ( | ||
<> | ||
<div className={styles.errorIcon}>{error.icon()}</div> | ||
<p className={styles.errorTitle}>{error.title}</p> | ||
<p className={styles.errorDescription}>{error.description}</p> | ||
</> | ||
) : ( | ||
<> | ||
<div className={styles.errorIcon}>{GenericError()}</div> | ||
<p className={styles.errorTitle}>{genericErrorTitle}</p> | ||
<p className={styles.errorDescription}> | ||
{error.message || error} | ||
</p> | ||
</> | ||
)} | ||
</div> | ||
) | ||
|
||
VisualizationErrorInfo.propTypes = { | ||
error: PropTypes.oneOfType([ | ||
PropTypes.instanceOf(Error), | ||
PropTypes.instanceOf(VisualizationError), | ||
]), | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
src/components/Visualization/styles/VisualizationErrorInfo.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
.errorContainer { | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
text-align: center; | ||
justify-content: center; | ||
width: 100%; | ||
} | ||
.errorIcon { | ||
width: 136px; | ||
height: 136px; | ||
margin: 0 auto var(--spacers-dp24); | ||
} | ||
.errorTitle { | ||
font-weight: 500; | ||
font-size: 20px; | ||
color: var(--colors-grey800); | ||
letter-spacing: 0.15px; | ||
line-height: 24px; | ||
width: 360px; | ||
margin: 0 auto var(--spacers-dp12); | ||
} | ||
.errorDescription { | ||
font-weight: 400; | ||
font-size: 14px; | ||
color: var(--colors-grey700); | ||
line-height: 19px; | ||
width: 360px; | ||
margin: 0 auto; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters