fix: compute subtotals/totals for boolean types (DHIS2-9155) #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3194.data-visualizer.netlify.dhis2.org |
edoardo
added
the
e2e record
Data Visualizer App
|
||||||||||||||||||||||||||||
| Project |
Data Visualizer App
|
| Branch Review |
fix/totals-for-boolean-types-DHIS2-9155
|
| Run status |
|
| Run duration | 09m 58s |
| Commit |
|
| Committer | Edoardo Sabadelli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
745
|
| View all changes introduced in this branch ↗︎ | |
edoardo
removed
the
e2e record
Since cli-app-scripts has already been updated to a version with the new plugin components, charts and PT have problems in dashboard because they still use the postRobot communication internally and the dashboard version does not use the new platform components. The skipPluginLogic flag avoids the issues by disabling the whole implementation in the platform plugin components at build time.
janhenrikoverland
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Tested here: dhis2/analytics#1700 (review)
Approved when:
- Version is updated
- Cypress tests for cumulative values are added
dhis2-bot
added a commit
that referenced
this pull request
Oct 18, 2024
## [100.8.1](v100.8.0...v100.8.1) (2024-10-18) ### Bug Fixes * compute subtotals/totals for boolean types (DHIS2-9155) ([#3194](#3194)) ([ebc0806](ebc0806))
|
🎉 This PR is included in version 100.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-9155
Requires dhis2/analytics#1696 and dhis2/analytics#1700
Key features
Description
The actual fix is in
analytics.See dhis2/analytics#1696 and dhis2/analytics#1700 for more details.
TODO
Update docs