Dhis2 18142/category option group forms #422
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ...DEFAULT_FIELD_FILTERS, | ||
| 'name', | ||
| 'shortName', | ||
| 'code', | ||
| 'description', | ||
| 'categoryOptions[id,displayName]', | ||
| 'dataDimension', | ||
| 'dataDimensionType', | ||
| 'attributeValues[value,attribute[id]]', |
There was a problem hiding this comment.
Minor, but can we use the constant ATTRIBUTE_VALUES_FIELD_FILTERS. eg.
| ...DEFAULT_FIELD_FILTERS, | |
| 'name', | |
| 'shortName', | |
| 'code', | |
| 'description', | |
| 'categoryOptions[id,displayName]', | |
| 'dataDimension', | |
| 'dataDimensionType', | |
| 'attributeValues[value,attribute[id]]', | |
| ...DEFAULT_FIELD_FILTERS, | |
| ...ATTRIBUTE_VALUES_FIELD_FILTERS, | |
| 'name', | |
| 'shortName', | |
| 'code', | |
| 'description', | |
| 'categoryOptions[id,displayName]', | |
| 'dataDimension', | |
| 'dataDimensionType', |
| export type CategoryFormValues = PickWithFieldFilters< | ||
| Category, | ||
| typeof fieldFilters |
There was a problem hiding this comment.
Please update name and Category import to CategoryOptionGroup.
| fields: fieldFilters.concat(), | ||
| }, | ||
| } | ||
| const categoryQuery = useQuery({ |
There was a problem hiding this comment.
Same here; let's keep this categoryOptionGroupQuery and the same for related types.
There was a problem hiding this comment.
Looks good, just some minor remnants from copy-pasting (which is perfectly valid here btw!).
Can you also add an entry for categoryOptionGroup to sectionListViewsConfig?
I think it makes sense to have much of the same config as category, but without categoryCombo as a filter.
After #423 is merged, we could also add categoryOption as a filter.
No description provided.