feat(ux): improve authenticatin field display with properly formatted auth details - DHIS2-20757#37
Conversation
… auth type and details
|
Works the same way if additional authentication methods are introduced. You can find the recording display in the Jira ticket: Testing deployment locally and no issues appear: Files Changed Summary
|
|
|
||
| .authField { | ||
| font-size: 12px; | ||
| color: #404b5a; /* colors.grey700 */ |
There was a problem hiding this comment.
Thanks for the review! I've updated this one as well as the other CSS line: line-height: var(--spacers-dp16);
| </div> | ||
| ) : ( | ||
| 'n/a' | ||
| <div>{i18n.t('No authentication')}</div> |
There was a problem hiding this comment.
maybe for the case with no authnetication, use a muted DataTableCell
so the condition has to be outside the cell (I also don't think it's valid to have divs inside td elements), and if no authentication, you'd have something like
<DataTableCell muted>{i18n.t('No authentication')}</DataTableCell>
There was a problem hiding this comment.
Thanks for the review! The muted one looks nice. I'd accidentally duplicated the DataTableCell but then fixed it. Removed the divs to span.
| {route.auth.type} | ||
| </div> | ||
| {Object.entries( | ||
| route.auth as Record< |
There was a problem hiding this comment.
don you need to cast it with as Record<.... - I wouldn't think that's necessary
There was a problem hiding this comment.
Removed that, thanks!
| // Verify auth type is displayed | ||
| expect(await findByText(expectedType)).toBeInTheDocument() | ||
| // Verify additional details are visible (no hover needed!) | ||
| for (const detail of expectedDetails) { |
There was a problem hiding this comment.
nice tests 👏🏿 .. I think you can simplify the tests for exampleDetails to just match the text without being an array, but using exact: false, or using a regex - https://testing-library.com/docs/queries/about/#precision
There was a problem hiding this comment.
Updated the tests.. :D thanks!
…ated in the last commit
|
# [100.7.0](v100.6.0...v100.7.0) (2026-02-16) ### Features * **DHIS2-20757:** improve authenticatin field display with properly formatted auth details ([#37](#37)) ([446c783](446c783))
|
🎉 This PR is included in version 100.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Implements DHIS2-20757