Skip to content

Commit

Permalink
Merge pull request #38 from fernandokkang/develop
Browse files Browse the repository at this point in the history
modify CodingTestRepository query
  • Loading branch information
dhktjr0204 authored Mar 19, 2024
2 parents 67a5fac + 8382fc6 commit 7ca6362
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_ACCESS_KEY }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.AWS_REGION }}

- name: Upload to AWS S3
Expand All @@ -67,4 +67,4 @@ jobs:
--application-name ${{ env.CODE_DEPLOY_APPLICATION_NAME }} \
--deployment-config-name CodeDeployDefault.AllAtOnce \
--deployment-group-name ${{ env.CODE_DEPLOY_DEPLOYMENT_GROUP_NAME }} \
--s3-location bucket=$S3_BUCKET_NAME,key=$GITHUB_SHA.zip,bundleType=zip
--s3-location bucket=$S3_BUCKET_NAME,key=$GITHUB_SHA.zip,bundleType=zip
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ public Optional<CodingTestDto> findByCodingTestId(long post_id, long user_id) {
"left join user u on p.user_id = u.id " +
"left join likes l on p.id = l.post_id " +
"where " +
"p.id = ? and p.type='COTE';";
"p.id = ? and p.type='COTE' " +
"group by p.id ";

try {
return Optional.of(jdbcTemplate.queryForObject(sql, codingTestDtoRowMapper(), user_id, post_id));
Expand Down
12 changes: 0 additions & 12 deletions src/main/resources/application.yml

This file was deleted.

0 comments on commit 7ca6362

Please sign in to comment.