Skip to content

Fixes #187 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhmay merged 2 commits into from
Jun 30, 2025
Merged

Fixes #187 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cee8e8
fixed another instance of value_counts().reset_index()
dhmay Jun 30, 2025
38bffe3
fixed version number in setup.py
dhmay Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='jamstats',
version='1.4.14',
version='3.4.14',
description='Data processing, stats and plots on roller derby scoreboard JSON files',
author='Damon May',
package_dir={"":"src"},
Expand Down
2 changes: 1 addition & 1 deletion setup_nogui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name='jamstats-nogui',
version='1.4.14',
version='3.4.14',
description='Data processing, stats and plots on roller derby scoreboard JSON files. No-GUI version.',
author='Damon May',
package_dir={"":"src"},
Expand Down
7 changes: 3 additions & 4 deletions src/jamstats/plots/basic_plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,8 @@ def plot(self, derby_game: DerbyGame) -> Figure:
pdf_team_penalties = derby_game.pdf_penalties[
derby_game.pdf_penalties.team == team
]
pdf_team_penalty_counts = (pdf_team_penalties
.penalty_name.value_counts().reset_index().rename(
columns={"penalty_name": "Penalty", "count": "Count"}))
pdf_team_penalty_counts = pdf_team_penalties.penalty_name.value_counts().reset_index()
pdf_team_penalty_counts.columns = ["Penalty", "Count"]
pdf_team_penalty_counts["team"] = team
pdf_team_penalty_counts.sort_values("Penalty", inplace=True)
pdf_team_penalty_counts["team_number"] = 1 if team == derby_game.team_1_name else 2
Expand Down Expand Up @@ -469,4 +468,4 @@ class SkaterStatsPlotTeam2(SkaterStatsPlotOneTeam):
name: str = "Team 2 Skaters"
description: str = "Skaters stats for team 2"
def __init__(self, anonymize_names: bool = False) -> None:
super(SkaterStatsPlotTeam2, self).__init__(2, anonymize_names=anonymize_names)
super(SkaterStatsPlotTeam2, self).__init__(2, anonymize_names=anonymize_names)
Loading