fixed parsing of version number #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #190 . When I attempted to load the derby.json file uploaded by @bullseye555 JamStats errored on parsing the version number. It looks like CRG changed the format of the version number again -- it used to begin with "v", and now it doesn't. I now strip the "v" if it's there not if it isn't. Should work on all existing version number formats and be less likely to fail in the future.
However, that's not the error that bullseye reported in issue 190 ("No Id column in roster"). I haven't reproduced that error on bullseye's file -- after I fixed the version number, everything is fine. So, I'm not sure this fix will completely address issue 190.