Conversation
Changes ~ 2 years ago to holstius/CALINE3 mean that CALINE3_RECEPTOR_TOTALS does not exist anymore; only CAL3RXM and CAL3RXL are possible targets for the do.call() via the CALINE3 package. Thus, running the San Francisco vignette dies on the do.call() in the predict() line. This adds a parameter to the predict function, defaulting to CAL3RXL, which allows the prediction to function, while still allowing the user to select between RXL and RXM models.
Fixes S3 predict function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do.call() references a non-existent function in CALINE3 package; added argument and defaulted to functional call. Seems to fix the issue, which can be seen in the San Francisco vignette where the predict() call fails due to being unable to find CALINE3_RECEPTOR_TOTALS.