feat(config.ts): add skipCommitMessageCheck config key#19
Open
Lars- wants to merge 3 commits intodi-sukharev:devfrom
Open
feat(config.ts): add skipCommitMessageCheck config key#19Lars- wants to merge 3 commits intodi-sukharev:devfrom
Lars- wants to merge 3 commits intodi-sukharev:devfrom
Conversation
Lars-
commented
Mar 15, 2023
Lars-
commented
- add skipCommitMessageCheck config key
- add support for skipCommitMessageCheck config key to skip commit message check if set to true
feat(prepare-commit-msg-hook.ts): add support for skipCommitMessageCheck config key to skip commit message check if set to true
Closed
src/commands/config.ts
Outdated
| description = 'description', | ||
| emoji = 'emoji' | ||
| emoji = 'emoji', | ||
| skipCommitMessageCheck = 'skipCommitMessageCheck' |
There was a problem hiding this comment.
lets rename it to skipCommitMsgHookSourceCheck?
Owner
There was a problem hiding this comment.
awesome @Lars- thanks! could you change base branch to dev instead of master pls <3
Owner
There was a problem hiding this comment.
@Lars- there is a conflict, could you solve pls and let's merge it!
Author
There was a problem hiding this comment.
The issue wasn't there when I sent the PR, so you may change it
…okSourceCheck refactor(prepare-commit-msg-hook.ts): update reference to skipCommitMessageCheck to skipCommitMsgHookSourceCheck update variable name
…n hook Added explanation to readme
Author
|
Also added a part to readme.md |
|
Stale pull request message |
Owner
|
please pull latest |
Author
|
I don’t have the time for that, but you should be able to change the code in the PR yourself. |
|
Am I missing this functionality in the current release or do I need to fork this repo? @di-sukharev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.