Implement audio preview fields #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salianifo
changed the title
|
Removed background previews for now until we can decide the implementation details. They can be added in a new PR later. |
Jowan-Spooner
added
Needs testing
|
Looks good to me for now. Possible changes to the audio events might require more work, but this is a cool addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #2440 Closes: #1072
Changed the audio previews to be built-in fields.
Added background previews as well since they both needed to be added to
event.gdandevent_block.gd.There is an issue with the background event (unrelated to this PR directly though):
_arg_typeisn't saved, so reloading the timeline thinks that the argument is an image again, causing the preview to show up with no image. This should be addressed separately though as it is unrelated to this PR.The background preview does cause a warning about fit expand modes not being supported by Flow Containers, but that doesn't effect the functionality at all. It is set this way as the image is given a predefined height for the preview, but can adapt to whatever width the image has.
Edit:
Removed background previews for now until we can decide the implementation details.