Skip to content

Fix multiple styles missing sound #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix multiple styles missing sound #2629

wants to merge 2 commits into from

Conversation

jinyangcruise
Copy link
Contributor

Fix #2628

@jinyangcruise jinyangcruise force-pushed the fix_multiple_styles_missing_sound branch from e27610a to d5fe2f9 Compare July 16, 2025 02:00
@Jowan-Spooner
Copy link
Member

Thanks for making this fix.
I think I have to revisit this when I have some time to think. This doesn't seem like a good way to fix this problem, as we generally do not store state data in the resources, only in the current_state_info dictionary, because that's what the save and load system stores. Otherwise the current mood might get lost. I think the current mood should already be stored in there, but maybe not in a good way, idk. I don't have enough time to properly asses this today, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using two bubble styles for two characters will make sound lost.
2 participants
@jinyangcruise @Jowan-Spooner