Godot 4.5 Compatibility: UID Fixes and remove SVGTexture references #2665
+5
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SVGTexture` class has been replaced with `DPITexture` in `field_file.tscn` to resolve the "Cannot get class 'SVGTexture'" error. All corresponding resource IDs have been updated accordingly. Additionally, incorrect UIDs for `timeline_editor.gd` and `shortcut_popup.gd` in `timeline_editor.tscn` have been corrected to match the actual file UIDs, resolving potential scene loading issues.
|
If |
CakeVR
added
Compatibility Breaking ⚠️
They are loaded at runtime anyways. This means they should continue to work correctly in every release.
|
Hey @uncleLukie thanks for the PR! As cake said both DPI Texture and SVGTexture (which was only available for a short while during the 4.5 dev phase aren't recognized by older godot versions. But I made a commit just removing the icons from the scene as they are loaded at runtime anyways. I guess godot changed what texture type get_theme_icon() returns. This way this should be good to go. Thanks again! |
Jowan-Spooner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request resolves critical errors and warnings when using Dialogic with the newly released Godot 4.5. The primary fixes include updating the deprecated SVGTexture to the new DPITexture and correcting invalid resource UIDs.
Changes:
SVGTexture to DPITexture: In Godot 4.5, the SVGTexture class has been renamed to DPITexture. This was causing an error (Cannot get class 'SVGTexture') when loading scenes that used the old class name. This has been fixed in addons/dialogic/Editor/Events/Fields/field_file.tscn by replacing all instances of SVGTexture with DPITexture.
Invalid UID Fixes: The timeline_editor.tscn file contained incorrect UIDs for the timeline_editor.gd and shortcut_popup.gd scripts. This has been resolved by updating the UIDs to match the actual file UIDs, which prevents any potential issues with script loading and scene integrity.