Skip to content

Commit

Permalink
Merge branch 'staging' into hackathon-rich-text-formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
braddialpad committed Dec 19, 2024
2 parents 0d2e34a + 2bbcc28 commit 180b8e0
Show file tree
Hide file tree
Showing 32 changed files with 291 additions and 268 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.json

Large diffs are not rendered by default.

22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# [9.92.0](https://github.com/dialpad/dialtone/compare/dialtone/v9.91.1...dialtone/v9.92.0) (2024-12-18)


### Features

* **Hovercard:** DP-119841 hovercard fixes for Fast Connect ([#597](https://github.com/dialpad/dialtone/issues/597)) ([e5c78a3](https://github.com/dialpad/dialtone/commit/e5c78a3d8896aeaee19e0da4fd9ee16ebaa033bf))

## [9.91.1](https://github.com/dialpad/dialtone/compare/dialtone/v9.91.0...dialtone/v9.91.1) (2024-12-18)


### Bug Fixes

* **Rich Text Editor:** DLT-2237 configure image extension to inline content so they will show up inside paragraph tags ([#598](https://github.com/dialpad/dialtone/issues/598)) ([da04964](https://github.com/dialpad/dialtone/commit/da0496400e89a25396a25bb5536e03d9ff2245f7))
* **Rich Text Editor:** NO-JIRA fix error when allowBulletList false ([#599](https://github.com/dialpad/dialtone/issues/599)) ([96b6134](https://github.com/dialpad/dialtone/commit/96b6134679ae3b7a87ac886901e900838dbcf800))

# [9.91.0](https://github.com/dialpad/dialtone/compare/dialtone/v9.90.0...dialtone/v9.91.0) (2024-12-16)


### Features

* **Feed Item Row:** DP-119844 add slot for displayName ([#596](https://github.com/dialpad/dialtone/issues/596)) ([c861ac1](https://github.com/dialpad/dialtone/commit/c861ac1af542b10e1dc1ee2ca0481dbfd661e418))

# [9.90.0](https://github.com/dialpad/dialtone/compare/dialtone/v9.89.0...dialtone/v9.90.0) (2024-12-14)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
</h2>
<a
class="d-btn d-btn--muted d-btn--outlined d-btn--lg"
href="https://dialpad.atlassian.net/secure/CreateIssue.jspa?issuetype=10975&pid=12508"
href="https://dialpad.atlassian.net/servicedesk/customer/portal/123/create/465"
target="_blank"
rel="noopener noreferrer"
>
Expand Down
2 changes: 0 additions & 2 deletions apps/dialtone-documentation/docs/components/hovercard.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ showHtmlWarning />

### Many hovercards

Initially, there is a 300ms delay when numerous hovercards are present. However, when transitioning from one anchor to another, the delay is determined by the mouse movement time. This implies that the closer the anchors are, the faster the hovercard appears. To achieve this, the component uses a global timer. Move the mouse over the avatars to reveal the hovercards in the example.

<code-well-header>
<dt-stack direction="row" gap="500">
<example-hovercard v-for="data in exampleData" :label="data.label" :content="data.content" />
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dialpad/dialtone",
"version": "9.90.0",
"version": "9.92.0",
"packageManager": "pnpm@9.9.0",
"description": "Dialpad's Dialtone design system monorepo",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/dialtone-vue2/CHANGELOG.json

Large diffs are not rendered by default.

22 changes: 22 additions & 0 deletions packages/dialtone-vue2/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# [2.170.0](https://github.com/dialpad/dialtone/compare/dialtone-vue2/v2.169.1...dialtone-vue2/v2.170.0) (2024-12-18)


### Features

* **Hovercard:** DP-119841 hovercard fixes for Fast Connect ([#597](https://github.com/dialpad/dialtone/issues/597)) ([e5c78a3](https://github.com/dialpad/dialtone/commit/e5c78a3d8896aeaee19e0da4fd9ee16ebaa033bf))

## [2.169.1](https://github.com/dialpad/dialtone/compare/dialtone-vue2/v2.169.0...dialtone-vue2/v2.169.1) (2024-12-18)


### Bug Fixes

* **Rich Text Editor:** DLT-2237 configure image extension to inline content so they will show up inside paragraph tags ([#598](https://github.com/dialpad/dialtone/issues/598)) ([da04964](https://github.com/dialpad/dialtone/commit/da0496400e89a25396a25bb5536e03d9ff2245f7))
* **Rich Text Editor:** NO-JIRA fix error when allowBulletList false ([#599](https://github.com/dialpad/dialtone/issues/599)) ([96b6134](https://github.com/dialpad/dialtone/commit/96b6134679ae3b7a87ac886901e900838dbcf800))

# [2.169.0](https://github.com/dialpad/dialtone/compare/dialtone-vue2/v2.168.1...dialtone-vue2/v2.169.0) (2024-12-16)


### Features

* **Feed Item Row:** DP-119844 add slot for displayName ([#596](https://github.com/dialpad/dialtone/issues/596)) ([c861ac1](https://github.com/dialpad/dialtone/commit/c861ac1af542b10e1dc1ee2ca0481dbfd661e418))

## [2.168.1](https://github.com/dialpad/dialtone/compare/dialtone-vue2/v2.168.0...dialtone-vue2/v2.168.1) (2024-12-14)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ export const argTypesData = {
},

// Props
open: {
control: {
type: 'boolean',
},
},
fallbackPlacements: {
description: `If the popover does not fit in the direction described by "placement",
it will attempt to change its direction to the "fallbackPlacements".
Expand Down
5 changes: 2 additions & 3 deletions packages/dialtone-vue2/components/hovercard/hovercard.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,8 @@ describe('DtHovercard Tests', () => {
await anchor.trigger('mouseleave');
await vi.runAllTimers();

content = getHovercardContent();

expect(content).toBeNull();
const dialog = document.querySelector('[data-qa="dt-hovercard__dialog"] > div');
expect(dialog.style.display).toBe('none');
});
});

Expand Down
42 changes: 33 additions & 9 deletions packages/dialtone-vue2/components/hovercard/hovercard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
:footer-class="footerClass"
:append-to="appendTo"
:hovercard="true"
:timer="timer"
data-qa="dt-hovercard"
:open="open"
:enter-delay="enterDelay"
:leave-delay="leaveDelay"
@opened="(e) => ($emit('opened', e))"
>
<template #anchor="{ attrs }">
Expand All @@ -39,9 +41,8 @@

<script>
import { POPOVER_APPEND_TO_VALUES, POPOVER_PADDING_CLASSES, DtPopover } from '@/components/popover/index.js';
import { TOOLTIP_DIRECTIONS } from '@/components/tooltip/index.js';
import { TOOLTIP_DIRECTIONS, TOOLTIP_DELAY_MS } from '@/components/tooltip/index.js';
import { getUniqueString } from '@/common/utils';
import useTimer from './timer';

export default {
name: 'DtHovercard',
Expand All @@ -52,6 +53,17 @@ export default {

props: {
/**
* Controls whether the hovercard is shown. Leaving this null will have the hovercard trigger on hover by default.
* If you set this value, the default trigger behavior will be disabled, and you can control it as you need.
* Supports .sync modifier
* @values null, true, false
*/
open: {
type: Boolean,
default: null,
},

/**
* Fade transition when the content display is toggled.
* @type boolean
* @values true, false
Expand Down Expand Up @@ -165,6 +177,24 @@ export default {
(appendTo instanceof HTMLElement);
},
},

/**
* The enter delay in milliseconds before the hovercard is shown.
* @type number
*/
enterDelay: {
type: Number,
default: TOOLTIP_DELAY_MS,
},

/**
* The leave delay in milliseconds before the hovercard is hidden.
* @type number
*/
leaveDelay: {
type: Number,
default: TOOLTIP_DELAY_MS,
},
},

emits: [
Expand All @@ -176,11 +206,5 @@ export default {
*/
'opened',
],

data () {
return {
timer: useTimer(),
};
},
};
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
:header-class="$attrs.headerClass"
:footer-class="$attrs.footerClass"
:append-to="$attrs.appendTo"
:open="$attrs.open"
:enter-delay="$attrs.enterDelay"
:leave-delay="$attrs.leaveDelay"
@opened="$attrs.onOpened"
>
<template #anchor="slotProps">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
:header-class="$attrs.headerClass"
:footer-class="$attrs.footerClass"
:append-to="$attrs.appendTo"
:enter-delay="$attrs.enterDelay"
:leave-delay="$attrs.leaveDelay"
@opened="$attrs.onOpened"
>
<template #anchor="slotProps">
Expand Down
67 changes: 0 additions & 67 deletions packages/dialtone-vue2/components/hovercard/timer.js

This file was deleted.

Loading

0 comments on commit 180b8e0

Please sign in to comment.