Skip to content

feat(avatar): DLT-3161 change from clickable to "interactive"#1182

Open
Brad Paugh (braddialpad) wants to merge 1 commit intonextfrom
DLT-3161
Open

feat(avatar): DLT-3161 change from clickable to "interactive"#1182
Brad Paugh (braddialpad) wants to merge 1 commit intonextfrom
DLT-3161

Conversation

@braddialpad
Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) commented Apr 7, 2026

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

  • Feature

📖 Jira Ticket

DLT-3161

📖 Description

Renames the clickable prop on DtAvatar to interactive for consistency with the broader Dialtone component API. The old clickable prop is retained as a deprecated backward-compatible fallback via a resolvedInteractive computed property that uses nullish coalescing.

💡 Context

The clickable naming was inconsistent with how other interactive components in Dialtone describe this behavior. Using interactive is more semantically accurate and aligns with the component API standardization effort.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

@wiz-inc-55b470eb7e
Copy link
Copy Markdown

Wiz Scan Summary

⚠️ Many findings detected
Many findings were detected, but only a subset of the findings are displayed inline due to API constraints. To view all findings inline, please click here.
Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 35 Medium 33 Low
Software Management Finding Software Management Findings -
Total 35 Medium 33 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review


P1 Badge Restore iconSize slot binding for avatar icon slot

Removing the scoped slot binding here makes iconSize undefined for all custom avatar icon slots, but several recipes still consume it (for example feed_item_row.vue, general_row.vue, and contact_info.vue all use #icon="{ iconSize }"). In those paths, icons now fall back to their default size instead of matching avatar size, causing visibly incorrect icon rendering in production UI wherever DtAvatar is customized via the icon slot.


return this.clickable ?? this.interactive;

P2 Badge Prefer interactive over deprecated clickable in resolution

This resolution gives the deprecated clickable prop precedence over the new interactive prop, so any caller that passes both during migration (for example with clickable: false in legacy defaults and interactive: true in new code) will unexpectedly remain non-interactive and stop emitting clicks. Since clickable is intended as a fallback compatibility path, the new prop should take priority when both are present.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as far as I'm concerned. I'm skeptical of Codex's two responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants