fix(toast): remove margin #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
|
✔️ Deploy Preview ready! |
|
Since this causes a visual change, I've put a first-child selector instead, so it only applies the margin if a button actually exists inside the element. |
|
✔️ Deploy Preview ready! |
braddialpad
pushed a commit
that referenced
this pull request
Nov 17, 2023
## [8.21.4](dialtone/v8.21.3...dialtone/v8.21.4) (2023-11-17) ### Bug Fixes * remove old icons from dialtone ([#11](#11)) ([0f6071f](0f6071f)) * **Toast:** remove margin ([#13](#13)) ([a29bd03](a29bd03)) ### Documentation * fix missing dependencies ([b9c41df](b9c41df)) * separate dialtone documentation site and library ([#6](#6)) ([c937293](c937293))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unnecessary left margin on toast. It is not needed as gap is being used.
Pull Request Checklist
stagingas your pull request's base branch. (All PRs usingproductionas its base branch will be declined).gulpscripts successfully compile.Obligatory GIF (super important!)