chore: add support for commonJS to esm #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamarina
requested review from
juliodialpad,
iropolo,
francisrupert and
braddialpad
as code owners
|
✔️ Deploy Preview ready! |
|
✔️ Deploy Preview ready! |
|
✔️ Deploy Preview ready! |
|
Jira status: https://dialpad.atlassian.net/browse/DLT-1288 |
|
✔️ Deploy Preview ready! |
braddialpad
approved these changes
Nov 24, 2023
6 tasks
ninamarina
added a commit
that referenced
this pull request
Nov 29, 2023
Updates the linting links in the CONTRIBUTING.md to be correct after #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://dialpad.atlassian.net/browse/DLT-1288
Description
Adds support for require commonJS modules to esm to avoid code duplication.
Plugin docs: https://github.com/originjs/vite-plugins/tree/main/packages/vite-plugin-commonjs
Pull Request Checklist
stagingas your pull request's base branch. (All PRs usingproductionas its base branch will be declined).gulpscripts successfully compile.Obligatory GIF (super important!)