Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix wide tables #16

Merged
merged 3 commits into from
Nov 19, 2023
Merged

docs: fix wide tables #16

merged 3 commits into from
Nov 19, 2023

Conversation

francisrupert
Copy link
Contributor

Description

  1. Adjusts layout to resolve TOC getting awkward. For now, I'm suppressing the TOC on smaller viewports, prioritizing the content to fill the viewport.
  2. Several other doc site layout tweaks.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
image

@francisrupert francisrupert self-assigned this Nov 17, 2023
@github-actions GitHub Actions
Copy link

✔️ Deploy Preview ready!
😎 Browse the preview: https://dialpad.design/deploy-previews/pr-16
🔨 If you experience an SSL issue then wait 2 minutes and try again.

braddialpad
braddialpad approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@francisrupert francisrupert merged commit 24f4f7c into staging Nov 19, 2023
2 checks passed
@francisrupert francisrupert deleted the docs/fix-wide-tables branch November 19, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@francisrupert francisrupert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francisrupert @braddialpad