chore: add contributing guide #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliodialpad
requested review from
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
|
✔️ Deploy Preview ready! |
braddialpad
reviewed
Nov 22, 2023
.github/CONTRIBUTING.md
Outdated
Comment on lines
12
to
13
| ## Dialtone Vue 3 | ||
| [CONTRIBUTING.md](../packages/dialtone-vue3/.github/CONTRIBUTING.md) |
There was a problem hiding this comment.
what is packages/dialtone-vue3?? this doesn't exist
There was a problem hiding this comment.
Oh sorry, I have it on my local because I'm working on that, will remove it for now.
braddialpad
approved these changes
Nov 22, 2023
|
Approved after you make the change. |
|
✔️ Deploy Preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added general contributing guide with links to specific contributing guides.
This will help us while we decide what else we want to add to general contributing guide.
Pull Request Checklist
stagingas your pull request's base branch. (All PRs usingproductionas its base branch will be declined).gulpscripts successfully compile.Obligatory GIF (super important!)