style: updated spot illus styles to be darkmode friendly #26
Conversation
yorbi-dp
added
documentation
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
| @@ -54,6 +53,8 @@ import SpotMaleLaptopTyping from '@dialpad/dialtone/lib/dist/vue/spot/SpotMaleLa | |||
| import SpotFileUpload from '@dialpad/dialtone/lib/dist/vue/spot/SpotFileUpload.vue'; | |||
| import SpotBrowserTableGraph from '@dialpad/dialtone/lib/dist/vue/spot/SpotBrowserTableGraph.vue'; | |||
| import SpotBrowserListCallout from '@dialpad/dialtone/lib/dist/vue/spot/SpotBrowserListCallout.vue'; | |||
| import SpotMind from '@dialpad/dialtone/lib/dist/vue/spot/SpotMind.vue'; | |||
| import SpotEmpty from '@dialpad/dialtone/lib/dist/vue/spot/SpotEmpty.vue'; | |||
There was a problem hiding this comment.
EmptyState is probably far too specific. Spot Illustration are mostly illustative and thus shouldn't imply too much how they'd be used — even if this one might be used for an empty state.
Yup, looks like this might be a Cache issue. @juliodialpad it's helping me taking a look at it! |
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
Fixed on preview after hard refreshing (cmd+shift+r) to remove browser cache. |
Thank you!! |
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
|
✔️ Deploy Preview ready! |
yorbi-dp
force-pushed
the
dlt-1359-spot-illustrations
branch
from
06212e0 to
71fe796
Compare
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
yorbi-dp
requested review from
juliodialpad,
iropolo,
braddialpad and
ninamarina
as code owners
| ```yaml | ||
| { | ||
| "import SpotIlluVueName from '@dialpad/dialtone/lib/dist/vue/spot/SpotIlluVueName.vue';" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
you can remove the braces and quotes. also set the language to js rather than yaml.
import SpotIlluVueName from '@dialpad/dialtone/lib/dist/vue/spot/SpotIlluVueName.vue';
| 5. Commit and push your branch to Dialtone. | ||
| 6. Open a pull request. | ||
| 7. Once approved it can be merged into staging and will go out in the next dialtone release. | ||
| 4. Import the Illustrations into the `BaseIcon.vue` file: |
There was a problem hiding this comment.
let's make this entire section for only spot illustrations instead of "For brand icons and spot illustrations" since brand icons have now been moved to dialtone-icons and have the same process as system icons. You should remove any steps related to brand icons from this section.
| } | ||
| ``` | ||
|
|
||
| 6. Verify your changes have been updated on the website by running `npm run start` and navigating to `localhost:4000`. |
There was a problem hiding this comment.
instead of npm run start in the monorepo it should now be pnpm run start:dialtone
| ``` | ||
|
|
||
| 6. Verify your changes have been updated on the website by running `npm run start` and navigating to `localhost:4000`. | ||
| If you would like to verify your final output svg file run `npm run build` and look in the `./lib/dist/svg` folder |
There was a problem hiding this comment.
pnpm nx build dialtone instead of npm run build
| ```yaml | ||
| { | ||
| "export default { | ||
| components: { | ||
| SpotIlluVueName, | ||
| } | ||
| }" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
same thing here with the extra braces / quotes
There was a problem hiding this comment.
Thank you! Fixed all the suggestions to the contribution.md file in the lastest commit.
|
✔️ Dialtone Deploy Preview ready! |
|
✔️ Dialtone-vue 3 Deploy Preview ready! |
|
🎉 This PR is included in version 8.22.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Disclaimer: This is a first (new) version of spot illustrations, the idea it's to improve the structure as well with more documentation and how to use on a next version.
Pull Request Checklist
stagingas your pull request's base branch. (All PRs usingproductionas its base branch will be declined).gulpscripts successfully compile.Obligatory GIF (super important!)