Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: DLT-1479 send blog post notification to #dialtone channel #272

Merged
merged 32 commits into from
Apr 18, 2024
Merged

ci: DLT-1479 send blog post notification to #dialtone channel #272

merged 32 commits into from
Apr 18, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Apr 17, 2024 •
edited
Loading

Send blog post notification to #dialtone channel

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will not increment the version number, but will still deploy to documentation site on release:

  • CI

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1479

📖 Description

  • Added action to send SMS on blog post
  • Created Google cloud function that uses the API_KEY secret to send the message to the channel. The authentication is handled via WIF so the token is never exposed and the request is secure.
  • Currently sending messsages to #dialtone-engbot-testing channel for testing purposes, once this is approved I'll update the cloud function to send messages to #dialtone.

💡 Context

We need to send communications to #dialtone channel on blog post

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.

@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Apr 17, 2024
@juliodialpad juliodialpad self-assigned this Apr 17, 2024
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

1 similar comment
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@juliodialpad juliodialpad marked this pull request as ready for review April 17, 2024 20:05
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-272/

@juliodialpad juliodialpad changed the title ci: DLT-1479 send test message ci: DLT-1479 send blog post notification to #dialtone channel Apr 18, 2024
ninamarina
ninamarina approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ninamarina ninamarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
image

Remember to remove what was added to test

@juliodialpad juliodialpad merged commit 67e2e4c into staging Apr 18, 2024
5 checks passed
@juliodialpad juliodialpad deleted the Send-blog-post-notification-to-channel branch April 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamarina ninamarina ninamarina approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@braddialpad braddialpad Awaiting requested review from braddialpad braddialpad is a code owner

@CoreyFirespotter CoreyFirespotter Awaiting requested review from CoreyFirespotter

@nickfirespotter nickfirespotter Awaiting requested review from nickfirespotter

@ChrisDialpad ChrisDialpad Awaiting requested review from ChrisDialpad

Assignees

@juliodialpad juliodialpad

Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @ninamarina