Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release component styles #28

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Nov 29, 2023

Description

This is a dummy PR to be able to release the new components styles and remove utility classes from Dialtone Vue.
This is the commit that I want to release: 66ba329

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

@ninamarina ninamarina marked this pull request as ready for review November 29, 2023 14:55
Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-28

Copy link

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-28

@juliodialpad
Copy link
Collaborator

Why do you need to do this? You should only run pnpm run release on local and that should reléase the packages. If it's not working, please contact me

Copy link
Collaborator

@juliodialpad juliodialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please contact me to check what's happening here

Copy link
Collaborator

@juliodialpad juliodialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nina

@ninamarina ninamarina merged commit 36bd126 into staging Nov 29, 2023
6 checks passed
@ninamarina ninamarina deleted the release/components-styles branch November 29, 2023 15:42
ninamarina pushed a commit that referenced this pull request Nov 29, 2023
# [8.22.0](dialtone/v8.21.5...dialtone/v8.22.0) (2023-11-29)

### Features

* release component styles ([#28](#28)) ([36bd126](36bd126))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants