Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dialtone vue2 #33

Merged
merged 5 commits into from
Dec 4, 2023
Merged

chore: add dialtone vue2 #33

merged 5 commits into from
Dec 4, 2023

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Dec 1, 2023 •
edited
Loading

Description

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

@juliodialpad juliodialpad self-assigned this Dec 1, 2023
braddialpad
braddialpad approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-33/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-33/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-33/

@juliodialpad juliodialpad merged commit 3c4f1cf into staging Dec 4, 2023
4 checks passed
@juliodialpad juliodialpad deleted the chore/add-dialtone-vue2 branch December 4, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@juliodialpad juliodialpad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @braddialpad