Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated d-svg class from component styles #39

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore: remove deprecated d-svg class from component styles #39

merged 4 commits into from
Dec 11, 2023

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Dec 7, 2023 •
edited
Loading

Description

Jira: https://dialpad.atlassian.net/browse/DLT-502

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

giphy

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-39/

@ninamarina ninamarina marked this pull request as ready for review December 7, 2023 18:13
@iropolo iropolo added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Dec 11, 2023
@iropolo
Copy link
Contributor

iropolo commented Dec 11, 2023 •
edited
Loading

I tried to trigger percy action with visual-test-ready label

@iropolo
Copy link
Contributor

iropolo commented Dec 11, 2023

Would be necessary to update visual_tests GHA

@ninamarina ninamarina force-pushed the remove/d-svg-components branch from 4501bdc to b5cbb71 Compare December 11, 2023 20:03
@github-actions GitHub Actions
Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-39/

@github-actions GitHub Actions
Copy link

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-39/

@juliodialpad juliodialpad added visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests and removed visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests labels Dec 11, 2023
@ninamarina ninamarina merged commit 91e3185 into staging Dec 11, 2023
6 of 7 checks passed
@ninamarina ninamarina deleted the remove/d-svg-components branch December 11, 2023 20:36
@ninamarina ninamarina mentioned this pull request Dec 12, 2023
Merged
6 tasks
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 8.22.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees
No one assigned
Labels
released visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ninamarina @iropolo @braddialpad @juliodialpad