Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(date-picker): added link to figma component #42

Merged
merged 2 commits into from
Dec 11, 2023
Merged

docs(date-picker): added link to figma component #42

merged 2 commits into from
Dec 11, 2023

Conversation

francisrupert
Copy link
Contributor

Description

  • Datepicker's Figma component now available, link to it.
  • Adjusted status of several components, e.g. icon: new → ready.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

@francisrupert francisrupert self-assigned this Dec 11, 2023
@francisrupert francisrupert marked this pull request as ready for review December 11, 2023 15:12
@github-actions GitHub Actions
Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-42/

iropolo
iropolo approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@francisrupert francisrupert merged commit cb31e7a into staging Dec 11, 2023
4 checks passed
@francisrupert francisrupert deleted the chore/datepicker-figma-link branch December 11, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iropolo iropolo iropolo approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@braddialpad braddialpad Awaiting requested review from braddialpad braddialpad is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@francisrupert francisrupert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francisrupert @iropolo