Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix visual and a11y test #45

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Conversation

juliodialpad
Copy link
Collaborator

Description

  • Fixed Visual tests
  • Fixed a11y tests
  • Added the possibility to change dialtone-vue's port by using PORT=XXXX pnpm run storybook so we can run dialtone-vue2 and dialtone-vue3 simultaneously if needed.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

@juliodialpad juliodialpad self-assigned this Dec 11, 2023
@juliodialpad juliodialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Dec 11, 2023
Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-45/

Copy link

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-45/

Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-45/

Copy link

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-45/

Copy link

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-45/

@juliodialpad
Copy link
Collaborator Author

Tests seem to be running correctly now, but we're missing the percy integration permissions on GitHub, once we have that integration setup, we'll have the workflow prompt again.

@juliodialpad juliodialpad merged commit 61e9368 into staging Dec 12, 2023
7 checks passed
@juliodialpad juliodialpad deleted the ci/fix-visual-and-a11y-test branch December 12, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants