Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor message input vue3 #46

Merged
merged 3 commits into from
Dec 12, 2023
Merged

feat: refactor message input vue3 #46

merged 3 commits into from
Dec 12, 2023

Conversation

sanjeevdialpad
Copy link
Contributor

@sanjeevdialpad sanjeevdialpad commented Dec 11, 2023 •
edited
Loading

Description

Message input currently includes notice, footer contents that make it hard to extend it for cases like standalone message input, edit message case etc. Hence we remove the need to have additional content and just have the message input with ability to show/hide individual buttons.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

refactor

@github-actions GitHub Actions
Copy link

✔️ Dialtone Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/deploy-previews/pr-46/

@github-actions GitHub Actions
Copy link

✔️ Dialtone-vue 2 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-46/

@github-actions GitHub Actions
Copy link

✔️ Dialtone-vue 3 Deploy Preview ready!
😎 Browse the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-46/

braddialpad
braddialpad approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple more questions about this, but I don't really want to hold this up. Just this one change and you're good to ship.

packages/dialtone-vue3/recipes/conversation_view/message_input/message_input.vue Outdated Show resolved Hide resolved
@sanjeevdialpad sanjeevdialpad added the no-visual-test Add this tag when the PR does not need visual testing label Dec 12, 2023
@sanjeevdialpad sanjeevdialpad merged commit 32130f9 into staging Dec 12, 2023
3 checks passed
@sanjeevdialpad sanjeevdialpad deleted the refactor-message-input branch December 12, 2023 01:03
braddialpad pushed a commit that referenced this pull request Dec 12, 2023
@semantic-release-bot
chore(release): dialtone-vue3/v3.98.0
e5291e3 
# [3.98.0](dialtone-vue3/v3.97.0...dialtone-vue3/v3.98.0) (2023-12-12)

### Documentation

* fix links, fix outdated documentation. ([#40](#40)) ([124082e](124082e))

### Features

* refactor message input vue3 ([#46](#46)) ([32130f9](32130f9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees
No one assigned
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjeevdialpad @braddialpad