feat(rich-text-editor): DLT-2237 add image extension to editor #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emariotti3
requested review from
juliodialpad,
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
emariotti3
force-pushed
the
DLT-2237-add-image-extension-to-editor
branch
from
b13ce9f to
2e64ff5
Compare
emariotti3
changed the title
braddialpad
requested changes
Dec 10, 2024
packages/dialtone-vue2/components/rich_text_editor/rich_text_editor.vue
Outdated
Show resolved
Hide resolved
|
merge in staging to fix the accessibility test issue. |
emariotti3
force-pushed
the
DLT-2237-add-image-extension-to-editor
branch
from
14ab8d7 to
c3699a4
Compare
|
Please add either the |
|
✔️ Deploy previews ready! |
braddialpad
approved these changes
Dec 10, 2024
braddialpad
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Eugenia Mariotti <eugenia.mariotti@dialpad.com>
braddialpad
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [9.87.0](dialtone/v9.86.2...dialtone/v9.87.0) (2024-12-12) ### Bug Fixes * recipes css cleanup ([#581](#581)) ([ba85404](ba85404)) * **Rich Text Editor:** DP-116205 fix line break related issues ([#573](#573)) ([a204fd4](a204fd4)) ### Features * **Callbar Button:** DLT-2211 add passthrough tooltip props ([#578](#578)) ([66cf439](66cf439)) * **Emoji:** NO-JIRA update emoji-toolkit to 9.0 ([#587](#587)) ([9684377](9684377)) * **Rich Text Editor:** DLT-2237 add image extension to editor ([#589](#589)) ([72cff78](72cff78))
braddialpad
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [2.168.0](dialtone-vue2/v2.167.1...dialtone-vue2/v2.168.0) (2024-12-12) ### Bug Fixes * recipes css cleanup ([#581](#581)) ([ba85404](ba85404)) * **Rich Text Editor:** DP-116205 fix line break related issues ([#573](#573)) ([a204fd4](a204fd4)) ### Features * **Callbar Button:** DLT-2211 add passthrough tooltip props ([#578](#578)) ([66cf439](66cf439)) * **Emoji:** NO-JIRA update emoji-toolkit to 9.0 ([#587](#587)) ([9684377](9684377)) * **Rich Text Editor:** DLT-2237 add image extension to editor ([#589](#589)) ([72cff78](72cff78))
braddialpad
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [3.161.0](dialtone-vue3/v3.160.1...dialtone-vue3/v3.161.0) (2024-12-12) ### Bug Fixes * recipes css cleanup ([#581](#581)) ([ba85404](ba85404)) * **Rich Text Editor:** DP-116205 fix line break related issues ([#573](#573)) ([a204fd4](a204fd4)) ### Features * **Callbar Button:** DLT-2211 add passthrough tooltip props ([#578](#578)) ([66cf439](66cf439)) * **Emoji:** NO-JIRA update emoji-toolkit to 9.0 ([#587](#587)) ([9684377](9684377)) * **Rich Text Editor:** DLT-2237 add image extension to editor ([#589](#589)) ([72cff78](72cff78))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(rich-text-editor): DLT-2237 add image extension to editor
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
DLT-2237
📖 Description
Added image extension to editor in order to be able to render images inside the editor.
For us to be able to support this we need to add the tiptap image extension to the editor.
💡 Context
We need this because as part of our implementation of the ‘forward’ feature for email, we want to add quotes to previous emails in the editor, and allow the user to edit the forwarded emails as desired.
However, the emails can contain inline images in the email body or as part of the email signatures, which would be included in the quotes.
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript. Read docs here: Dialtone Vue Sync Script📷 Screenshots / GIFs
🔗 Sources
tiptap image extension