Conversation
Includes changes in resources/ up to and including upstream commit 41b0976dcf35: "[maven-release-plugin] prepare release v8.12.44"
Includes changes in resources/ up to and including upstream commit 0ea664e5e89d: "[maven-release-plugin] prepare release v8.12.45"
Includes changes in resources/ up to and including upstream commit 3b8e317bc7e7: "[maven-release-plugin] prepare release v8.12.46"
Includes changes in resources/ up to and including upstream commit e43c69d31a1d: "[maven-release-plugin] prepare release v8.12.47"
Add analogues of new upstream tests, with somewhat different behaviour because metadata loading is different.
Includes changes in resources/ up to and including upstream commit 4e7922d02168: "[maven-release-plugin] prepare release v8.12.48"
Includes changes in resources/ up to and including upstream commit 0815b3b99811: "[maven-release-plugin] prepare release v8.12.49"
Includes changes in resources/ up to and including upstream commit e1c6752b3585: "[maven-release-plugin] prepare release v8.12.50"
Includes changes in resources/ up to and including upstream commit 80683407f4cb: "[maven-release-plugin] prepare release v8.12.51"
Includes changes in resources/ up to and including upstream commit 011d35d28fe8: "[maven-release-plugin] prepare release v8.12.52"
Includes changes in resources/ up to and including upstream commit d1cc64365e1c: "[maven-release-plugin] prepare release v8.13.29"
Includes changes in resources/ up to and including upstream commit 9f8d93638ca3: "[maven-release-plugin] prepare release v8.13.30"
Includes changes in resources/ up to and including upstream commit e47049b1f77b: "[maven-release-plugin] prepare release v8.13.31"
Summary: TEL-12621 - Unable dial new Poland Police prefix +48 47 731 4848 Test Plan: added Reviewers: jerin Differential Revision: https://phabricator.fspot.us/D14990
Summary: Picked these regex changes from the build branch of Google. https://github.com/google/libphonenumber/blob/bc215578007c2a985a37f20597a5067744dca6b9/javascript/i18n/phonenumbers/metadatalite.js The changes will take time to make it through the google release and the david's phone numbers lib. For the migration on Jan 31st we need to push this lib changes for the numbers to be edited and added on product Test Plan: NA Reviewers: nick, jerin Reviewed By: nick Differential Revision: https://phabricator.fspot.us/D15409
Ariel Ickowicz (aickowicz-dp)
requested a review
from JerinDialpad (JerinDialpad)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please report changes to metadata to the upstream libphonenumber
project rather than here.
Do not send pull requests with changes in files under any of the following directories:
resources/python/phonenumbers/data/python/phonenumbers/carrierdata/python/phonenumbers/shortdata/python/phonenumbers/geodata/python/phonenumbers/tzdata/All of these directories hold code that is autogenerated from the metadata in the
resources/directory, which is anexact copy of the equivalent directory in the
upstream project.