-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Diablo Version 1.08-Specific Behavior with Preprocessor Directives #2292
Conversation
Might want to add the flags here: https://github.com/diasurgical/devilution/blob/master/MakefileVC#L58 |
I did a minor change that should allow better handling of building the binary based on targeted version of Diablo. This way we can conditionally handle changes that can span multiple Diablo versions. Perhaps then after another few PRs for different version logic, we could decouple |
diasurgical#2292) * add preprocessor directive for version 1.08 * Update MakefileVC * Missed "endif" * revise handling of diablo version
diasurgical#2292) * add preprocessor directive for version 1.08 * Update MakefileVC * Missed "endif" * revise handling of diablo version
diasurgical#2292) * add preprocessor directive for version 1.08 * Update MakefileVC * Missed "endif" * revise handling of diablo version
diasurgical#2292) * add preprocessor directive for version 1.08 * Update MakefileVC * Missed "endif" * revise handling of diablo version
diasurgical#2292) * add preprocessor directive for version 1.08 * Update MakefileVC * Missed "endif" * revise handling of diablo version
Build for version 1.08 binary. The difference between v1.09b and v1.08 is weighting in pathfinding, and fixing sound issues, however nothing in the original source had been changed between v1.09 and v1.09b, but rather using a different version of the directsound API
v1.08
path_get_h_cost()
is found at 0x44A911v1.09/v1.09b
path_get_h_cost()
is found at 0x4494D3