Skip to content

Conversation

sshivam95
Copy link
Contributor

@sshivam95 sshivam95 commented Sep 11, 2025

Fix to issue #328

@sshivam95 sshivam95 self-assigned this Sep 11, 2025
@sapkotaruz11
Copy link
Member

@sshivam95 could you write a test case where you first run one experiment and then re-use the same experiment dir ( the current use case) for new experiment ?

args1.reuse_existing_run_dir = False
args1.random_seed = 42
args1.save_embeddings_as_csv = False
args1.eval_model = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case also for cases where the model is evaluated after the training, current setup looks like it will fail in post-training evaluation e.g, use dataset UMLS , eval_mode "train_test_val" and pandas backend

args2.reuse_existing_run_dir = True
args2.random_seed = 42
args2.save_embeddings_as_csv = False
args2.eval_model = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case also for cases where the model is evaluated after the training, current setup looks like it will fail in post-training evaluation e.g, use dataset UMLS , eval_mode "train_test_val" and pandas backend

@Demirrr Demirrr merged commit 390081d into develop Oct 13, 2025
3 checks passed
@Demirrr Demirrr deleted the reuse-or-reset-run-dir branch October 13, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants