-
Notifications
You must be signed in to change notification settings - Fork 15
Reuse or reset run dir #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sshivam95 could you write a test case where you first run one experiment and then re-use the same experiment dir ( the current use case) for new experiment ? |
args1.reuse_existing_run_dir = False | ||
args1.random_seed = 42 | ||
args1.save_embeddings_as_csv = False | ||
args1.eval_model = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case also for cases where the model is evaluated after the training, current setup looks like it will fail in post-training evaluation e.g, use dataset UMLS , eval_mode "train_test_val" and pandas backend
args2.reuse_existing_run_dir = True | ||
args2.random_seed = 42 | ||
args2.save_embeddings_as_csv = False | ||
args2.eval_model = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case also for cases where the model is evaluated after the training, current setup looks like it will fail in post-training evaluation e.g, use dataset UMLS , eval_mode "train_test_val" and pandas backend
… into reuse-or-reset-run-dir
Fix to issue #328