Merged
Conversation
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
2 times, most recently
from
0aaa468 to
d07d874
Compare
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
9 times, most recently
from
0755b19 to
856c990
Compare
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
2 times, most recently
from
8ac5858 to
cc38c89
Compare
rustamdantia
changed the title
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
5 times, most recently
from
0ece6dd to
00a6ecc
Compare
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
from
3896f74 to
93aae32
Compare
astoff
approved these changes
Dec 10, 2024
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
from
6ded720 to
292457a
Compare
astoff
approved these changes
Jan 23, 2025
Comment on lines
+322
to
+335
| log.error(msg, location_name, extracted_product_file_name) | ||
| raise RuntimeError( | ||
| msg % (msg, location_name, extracted_product_file_name) | ||
| ) |
Collaborator
There was a problem hiding this comment.
I think the main idea is that you would have one single base class for Geographer errors so that your users can have a simple "fallback" way to handle all errors coming from the library. And then you can progressively define more specific error types (as can your users in their error handling code).
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
4 times, most recently
from
018ec13 to
4e90c16
Compare
…for Python 3.8, add support for 3.10-13.
rustamdantia
force-pushed
the
replace-sentinelsat-with-eodag
branch
from
4e90c16 to
b6dc5ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__logic in DSCreatorFromSource with pydantic validators.