Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the URL of an item via wikidata P953 value #237

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Futur3r
Copy link
Contributor

@Futur3r Futur3r commented Jan 22, 2023

Working on #235 .

I'm trying to get the value of the P953 statement of a WD element via the Wikidata.getProperties() method without success.

src/zoteroOverlay.jsx Outdated Show resolved Hide resolved
@Dominic-DallOsto
Copy link
Collaborator

Hey, sorry I'm a bit slow to review this!

At the moment this is just setting the URL of the item, but the goal would rather be to download the the PDF from that URL and add it as an attachment right?

@Futur3r
Copy link
Contributor Author

Futur3r commented Feb 1, 2023

Yes, it is the goal.

But for me it seemed a lot of work and a bit beyond my skills. As I wanted this kind of functionality now, I started to code something easier for me and close enough. Also, I think this functionality would be good to have.

@Futur3r
Copy link
Contributor Author

Futur3r commented Feb 14, 2023

Actually, maybe just this functionality is enough, what do you think ?
This could be merged now, but the issue can stay open.

@Futur3r Futur3r marked this pull request as ready for review February 14, 2023 16:16
@Futur3r Futur3r changed the title Fetch an open access PDF via P953 Update the URL of an item via wikidata P953 value Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants