Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mw][e2e] Add miniwallet<->drw proxy #60

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[mw][e2e] Add miniwallet<->drw proxy #60

merged 1 commit into from
Mar 4, 2021

Conversation

CapCap
Copy link
Contributor

@CapCap CapCap commented Mar 2, 2021

Motivation

Add a proxy so the miniwallet can drive DRW for testing

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Run the miniwallet tests pointed at the MW-DRW proxy

This has already identified two potential bugs in the DRW:
#62
#63

@CapCap CapCap marked this pull request as draft March 2, 2021 21:01
backend/tests/mw_drw_proxy/proxy.py Outdated Show resolved Hide resolved
backend/tests/mw_drw_proxy/proxy.py Show resolved Hide resolved
backend/tests/mw_drw_proxy/proxy.py Outdated Show resolved Hide resolved
backend/tests/mw_drw_proxy/proxy.py Outdated Show resolved Hide resolved
@CapCap CapCap marked this pull request as ready for review March 3, 2021 20:06
backend/tests/e2e_tests/__init__.py Outdated Show resolved Hide resolved
backend/tests/mw_drw_proxy/proxy.py Outdated Show resolved Hide resolved
backend/tests/mw_drw_proxy/proxy.py Show resolved Hide resolved
@CapCap CapCap requested a review from xli March 3, 2021 23:09
@xli xli requested a review from sunmilee March 4, 2021 01:38
@sunmilee
Copy link
Contributor

sunmilee commented Mar 4, 2021

Can you update readme to have steps to run tests using mini wallet?

@CapCap CapCap merged commit 648d3d4 into diem:master Mar 4, 2021
@CapCap CapCap deleted the add_mw_drw_proxy branch March 4, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants