Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Java regression test sources (1/n) #8487

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Oct 29, 2024

in preparation to removing all Java compilation products from the repository so that we can eventually compile and test with different JDK versions. We use Maven to compile all Java test sources up-front, each test directory becomes a module. This is significantly faster than calling javac directly for each test directory (because of javac start-up time).

This PR includes the integration of the compilation process (first commit) and two examples how it is going to be used:

  • test with single source file
  • test that requires jar

There are several test directories that require different kinds of custom compilation, using Jasmin, ASM, etc, which can be handled by customising the build process in the pom.xml files of each test module.

  • Each commit message has a non-empty body, explaining why the change was made.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel force-pushed the ps/compile-java-regression-test-sources1 branch 2 times, most recently from d2209c3 to 15524c7 Compare November 10, 2024 22:25
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (0db546b) to head (9e595aa).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8487   +/-   ##
========================================
  Coverage    78.76%   78.76%           
========================================
  Files         1728     1728           
  Lines       198925   198925           
  Branches     18313    18330   +17     
========================================
  Hits        156686   156686           
  Misses       42239    42239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit adds the CMake integration to call Maven
to compile the test sources.
Add pom.xml for compilation,
move sources
remove obsolete pre-compiled class file.
Fix pom.xml for compilation,
remove obsolete pre-compiled jar file.
which makes more sense than building with cmake
and cleaning with make.
@peterschrammel peterschrammel force-pushed the ps/compile-java-regression-test-sources1 branch from 15524c7 to 9e595aa Compare November 12, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant