Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate SATCHECK_* defines #8501

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

kroening
Copy link
Member

The SATCHECK_* defines (e.g., SATCHECK_MINISAT2) are defined both in src/solvers/satcheck.h, and in config.inc.

This removes the instance in config.inc, in an effort to de-clutter the compiler command line. Users of the macros can include the header file.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The SATCHECK_* defines (e.g., SATCHECK_MINISAT2) are defined both in
src/solvers/satcheck.h, and in config.inc.

This removes the instance in config.inc, in an effort to de-clutter the
compiler command line.  Users of the macros can include the header file.
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (83f61a4) to head (fd53c32).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8501   +/-   ##
========================================
  Coverage    78.76%   78.76%           
========================================
  Files         1728     1728           
  Lines       198925   198925           
  Branches     18326    18295   -31     
========================================
  Hits        156686   156686           
  Misses       42239    42239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review November 11, 2024 09:45
@tautschnig tautschnig merged commit 0db546b into develop Nov 12, 2024
41 checks passed
@tautschnig tautschnig deleted the cleanup-SATCHECK-defines branch November 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants