Skip to content

Commit 4a1af8c

Browse files
Refactor to use new .get(), and better support Default dataset
1 parent 47c40e8 commit 4a1af8c

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

sdk/diffgram/core/core.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
class Project():
2222
default_directory: Directory
2323
last_response_header: None
24+
directory_list: list
2425

2526
def __init__(
2627
self,
@@ -34,6 +35,7 @@ def __init__(
3435
refresh_local_label_dict = True
3536

3637
):
38+
self.directory_list = []
3739

3840
self.session = requests.Session()
3941
adapter = requests.adapters.HTTPAdapter(pool_connections = 30, pool_maxsize = 30)
@@ -84,7 +86,6 @@ def __init__(
8486

8587
self.label_schema_list = self.get_label_schema_list()
8688

87-
self.directory_list = None
8889

8990

9091
def get_member_list(self):
@@ -314,8 +315,11 @@ def set_default_directory(self,
314315
if directory is not None:
315316
self.directory_id = directory.id
316317
self.default_directory = directory
317-
if not hasattr(self, 'directory_list'):
318-
self.directory_list = self.directory.get_directory_list()
318+
319+
if self.directory_id is None:
320+
default_directory = self.directory.get()
321+
self.directory_id = default_directory.id
322+
self.default_directory = default_directory
319323

320324
self.session.headers.update(
321325
{'directory_id': str(self.directory_id)})

sdk/diffgram/core/directory.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ def list_files(
299299
return file_list
300300

301301
def get(self,
302-
name: str):
302+
name: str = None):
303303

304304
"""
305305
@@ -310,8 +310,6 @@ def get(self,
310310
TODO refactor set_directory_by_name() to use this
311311
312312
"""
313-
if name is None:
314-
raise Exception("No name provided.")
315313

316314
# Cache
317315
if not self.client.directory_list:

0 commit comments

Comments
 (0)