fix: add support for ktfmt's TrailingCommaManagementStrategy #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: also updated JVM version to 17
# Conflicts: # CHANGES.md # plugin-maven/CHANGES.md
|
Could a maintainer trigger the workflow runs for this once more? The first run failed due to failing format checks in the Also, I'd be happy to get some feedback to know if there's more work required to get this merged. :) |
|
A bit late, but thanks a lot @nedtwigg for taking this the rest of the way! |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and makes #2400 obsolete
Important Note: This PR also upgrades the JVM version in
gradle/java-publish.gradleandgradle.propertiesfrom 11 to 17java.lang.NoSuchMethodError#2482TODO
KtfmtStepTestONLY_ADD0.53(previous default) and0.57(or0.58). Maybe @hick209 or someone from the ktfmt team has an opinion if that is sensible or what to test here.KtfmtTestfrom Maven plugin test passes