Digg 472 Follow specification face #526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser navigation fix
DIGG-450: Fixing organisation page name
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data.terms.termsInfo = termsList | ||
| .map((t) => ({ | ||
| title: getLocalizedValue(t.getAllMetadata(), "dcterms:title"), | ||
| url: t.getResourceURI().startsWith("https://dataportal.se") |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 months ago
To fix the problem, we need to parse the URL and check its host value instead of using a simple string comparison. This ensures that the check handles arbitrary subdomain sequences correctly and prevents bypassing the security check.
- Parse the URL using the
URLconstructor to extract the host value. - Compare the host value with the allowed host "dataportal.se".
- Update the relevant code in the file
providers/entrystore-provider/index.tsx.
Suggested changeset
1
providers/entrystore-provider/index.tsx
| @@ -566,3 +566,3 @@ | ||
| title: getLocalizedValue(t.getAllMetadata(), "dcterms:title"), | ||
| url: t.getResourceURI().startsWith("https://dataportal.se") | ||
| url: new URL(t.getResourceURI()).host === "dataportal.se" | ||
| ? new URL(t.getResourceURI()).pathname.replace( |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New filter on datasets that follows a soecification.
https://dgroupse.atlassian.net/browse/DIGG-472