Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGG-483: Uppdating url structure for concepts, terminologies and specifications #530

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

MikaMunterud
Copy link
Contributor

Pull Request Description

Handling entries in two different ways depending on if it is an so called external specification or internal specification makes the code more difficult to handle when different cases needs to fetched from entrystore in different ways.

It is better to handle them in the same way as datasets and organisations where the context id and entry id is used to fetch the entry from entrystore.

This code includes handling of permanent redirecting the old url structures to the new format. This has been tested to be inputted in a middleware but it seems like the middleware has restrictions regarding imported functions, for example EntryStore or outside functions that uses EntryStore. For that reason is the redirection handled in each path that has been previously used.

Checklist

  • Changes are limited to a single goal (avoid scope creep)
  • I confirm that I have read any Contribution and Development guidelines (CONTRIBUTING and DEVELOPMENT) and are following their suggestions.
  • I confirm that I wrote and/or have the right to submit the contents of my Pull Request, by agreeing to the Developer Certificate of Origin, (adding a 'sign-off' to my commits).

@MikaMunterud MikaMunterud requested a review from Kopin1 December 6, 2024 17:05
pages/concepts/[concept]/index.tsx Outdated Show resolved Hide resolved
@MikaMunterud MikaMunterud requested a review from Kopin1 December 7, 2024 14:47
Copy link
Collaborator

@Kopin1 Kopin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MikaMunterud MikaMunterud merged commit bfcc06a into dev Dec 9, 2024
1 check passed
@MikaMunterud MikaMunterud deleted the DIGG-483 branch December 19, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants