Apply suggestions from code review

Co-authored-by: Elise Haldane <107867060+elisehaldane@users.noreply.github.com>
digicatapult · Mar 21, 2024 · 2cbe8a8 · 2cbe8a8
1 parent 69169ed
commit 2cbe8a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/config.sh b/config.sh
@@ -10,8 +10,8 @@ if [ "$1" != '--url' ] || [ "$3" != '--token' ]; then
 fi
 
 # Generate a random string for the runner name, if using config.sh without variables
-export RANDOM
 RANDOM="$(LC_ALL=C tr -dc 'a-zA-Z0-9' < /dev/urandom | head -c 8)"
+export RANDOM
 . ${SCRIPTDIR}/check-envs.sh
 
 mkdir -p ${RUNNER_CONFIG_DIRECTORY}

diff --git a/flavours/github-act.sh b/flavours/github-act.sh
@@ -10,7 +10,7 @@ if [ "$NAME" = "FreeBSD" ]; then
     echo "FreeBSD update completed."
 fi
 
-if [ "$NAME" = "FreeBSD" ] || [ "$NAME" = "CheriBSD" ]; then
+if [ "$NAME" = "CheriBSD" ]; then
     echo "skipped freebsd-update for $NAME"
 fi