Bugfix/code snippet #105
Merged
Bugfix/code snippet #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lievenvg
requested review from
TriangleJuice,
jsprds,
jsebrech and
TomVanDenBroeck
TomVanDenBroeck
approved these changes
Jan 24, 2019
TomVanDenBroeck
approved these changes
Jan 24, 2019
jsebrech
reviewed
Jan 24, 2019
| @@ -36,7 +36,7 @@ export class CodeSnippetComponent implements OnChanges, AfterViewChecked { | |||
| if (this.processMarkdown) { this.codeSnippet = marked(this.codeSnippet); } | |||
| } | |||
|
|
|||
| public ngAfterViewChecked() { | |||
| public ngAfterViewInit() { | |||
There was a problem hiding this comment.
Does this re-highlight when the codeSnippet attribute is changed?
There was a problem hiding this comment.
As mentioned in person, the previous and new behaviour don't support dynamic updating of the highlighting. I opened a separate issue #107 for this.
TriangleJuice
approved these changes
Jan 24, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
App is responding very slowly and is cpu intensive.
Issue Number: #62
What is the new behavior?
App is responding smoothly.
Does this PR introduce a breaking change?
Other information
Resolved issues
Closes: #62
Fixes: #62
Resolves: #62