Skip to content

Conversation

bame-da
Copy link
Contributor

@bame-da bame-da commented Jan 25, 2023

This pulls in executablebooks/sphinx-external-toc#88 and thus enables live-preview of ToC title changes.

Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very unenthused by the addition of an opaque binary file like that. How was it produced?

@bame-da
Copy link
Contributor Author

bame-da commented Jan 25, 2023

flit build on executablebooks/sphinx-external-toc#88.
We could checkout the code pointing to a commit hash so I can't modify it anymore, and run python -m pip install flint && flint install to install from source.

@garyverhaegen-da
Copy link
Contributor

flit build on executablebooks/sphinx-external-toc#88.
We could checkout the code pointing to a commit hash so I can't modify it anymore, and run python -m pip install flint && flint install to install from source.

I'd prefer that, yes, especially if there's a relatively easy way to do that within .envrc directly, with some way to check whether it needs to be done (i.e. it's been done already).

@bame-da
Copy link
Contributor Author

bame-da commented Jan 25, 2023

@garyverhaegen-da I gave it a shot, but I do use direnv... Does this work for you?

@garyverhaegen-da
Copy link
Contributor

@garyverhaegen-da I gave it a shot, but I do use direnv... Does this work for you?

Yes, that's pretty much what I had in mind, sorry if I wasn't clear.

@bame-da bame-da enabled auto-merge (squash) January 25, 2023 13:59
@bame-da bame-da disabled auto-merge January 25, 2023 13:59
@bame-da bame-da enabled auto-merge (squash) January 25, 2023 13:59
@bame-da bame-da merged commit fd06deb into main Jan 25, 2023
@bame-da bame-da deleted the use-local-plugin branch January 25, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants