-
Notifications
You must be signed in to change notification settings - Fork 1
Modernize #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernize #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see this as .yaml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in dc069e9
Just curious, is the preference for yaml
vs yml
a style thing or is there another reason to prefer one over the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.yaml
is, and has been, the official recommended extension since 2006.
https://yaml.org/faq.html
https://web.archive.org/web/20060924190202/http://yaml.org/faq.html
What reason is there to use .yml
? I find it odd that's supported at all. Does anyone use .jsn
?
I shall continue fighting this battle one file at a time.
I have wondered if a template repo should pretend to be a real thing or if every place "module-template-http" and similar is mentioned it should say "FIXME-http". That would make it easier to grep for FIXME to know all the misc places you need to update. Easy to miss something. But also nice the template itself is runnable and testable. |
We do try to avoid merge commits, but it's not that big of a deal. I think it'd be easier here to rebase on main. I adjusted the repo settings to avoid the merge commits going forward. |
Co-authored-by: David I. Lehn <dil@lehn.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at this in too much detail, but I can see that it's clearly a big improvement over what we had before and +1 on that basis alone.
Updates template to use latest dependencies and conventions.
This branches from 0061c2b to remove the merge commit currently found in main. Commit 09639a9 was cherry picked onto this PR to preserve the history. If the merge commit is not a concern I can rebase onto the latest to get rid of the merge conflicts in this PR.