Skip to content

Conversation

tolson4
Copy link

@tolson4 tolson4 commented Jul 21, 2025

Updates template to use latest dependencies and conventions.

This branches from 0061c2b to remove the merge commit currently found in main. Commit 09639a9 was cherry picked onto this PR to preserve the history. If the merge commit is not a concern I can rebase onto the latest to get rid of the merge conflicts in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see this as .yaml.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in dc069e9

Just curious, is the preference for yaml vs yml a style thing or is there another reason to prefer one over the other?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.yaml is, and has been, the official recommended extension since 2006.
https://yaml.org/faq.html
https://web.archive.org/web/20060924190202/http://yaml.org/faq.html

What reason is there to use .yml? I find it odd that's supported at all. Does anyone use .jsn?

I shall continue fighting this battle one file at a time.

@davidlehn
Copy link
Member

I have wondered if a template repo should pretend to be a real thing or if every place "module-template-http" and similar is mentioned it should say "FIXME-http". That would make it easier to grep for FIXME to know all the misc places you need to update. Easy to miss something. But also nice the template itself is runnable and testable.

@davidlehn
Copy link
Member

We do try to avoid merge commits, but it's not that big of a deal. I think it'd be easier here to rebase on main. I adjusted the repo settings to avoid the merge commits going forward.

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this in too much detail, but I can see that it's clearly a big improvement over what we had before and +1 on that basis alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants