Fix contact insertion

[david-venhoff]

Short description

On the testserver we have multiple possible backend urls, and the contacts were previously loaded using their complete server url. For example, if a user was on https://cms-test.integreat-app.de the contact was still loaded using https://integreat-test.tuerantuer.org. Then the login form would be returned, because the user had of course no valid session for the other url.

So instead of using full urls, we can just use relative urls, like we do for all other links.

It's a bit hard to test this pr, because everything worked anyways on localhost, but I hope the explanation helps :)

I also considered adding redirect: "error", to the fetch call. This would at least have prevented that the full login form gets pasted. But maybe that is something we should add to all our fetch calls?

Proposed changes

• Don't use the full url

Side effects

Should be none

Resolved issues

Fixes: #3304

---

Pull Request Review Guidelines

[charludo]

Thank you for taking this on so quickly!

Curious, do you think we could just adjust the full_url definition?

[david-venhoff]

Curious, do you think we could just adjust the full_url definition?

I think that should also be possible. It would probably be a bit more robust, because it would make contact cards independent of base url changes

[david-venhoff]

@charludo
I tried your approach and one problem is that apparently tinymce tries to make every url absolute. So for example if the contact cards contains the url /augsburg/contact/5 then tinymce will convert it into https://integreat.app/augsburg/contact/5/ and that will mean that the get_referencing_x functions will not find it anymore, because they only look for relative urls…

I'm not sure if there is a way to get this to work, do you have an idea?

[charludo]

@charludo I tried your approach and one problem is that apparently tinymce tries to make every url absolute. So for example if the contact cards contains the url /augsburg/contact/5 then tinymce will convert it into https://integreat.app/augsburg/contact/5/ and that will mean that the get_referencing_x functions will not find it anymore, because they only look for relative urls…

I'm not sure if there is a way to get this to work, do you have an idea?

Huh, I didn't even think to make the URLs relative - I think that may be a great solution though? Although that might mean we need to expose the contacts via API as well

[charludo]

I am sorry, I just re-read my comment from before the holidays, and it makes no sense. I have no idea what I was thinking. Super sorry about that.

Upon reconsideration, this looks like a great solution to the problem 😄 🎉

[charludo]

Curious, do you think we could just adjust the full_url definition?

I think that should also be possible. It would probably be a bit more robust, because it would make contact cards independent of base url changes

Actually, could you implement this solution after all? 🙈
I'm working on #3258 and it's become necessary to use the full_url in additional places, so I think we should solve this issue at the lowest level possible.

Sorry for the flip-flopping 😭

[charludo]

@david-venhoff I made the changes we talked about, would you might taking another look if this is OK like this?

[david-venhoff]

Looks good to me. Lets hope that it works