Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest users potential contact sources #3314

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Jan 3, 2025

Short description

This PR introduces a hint page to help users to create new contacts and replace embedded E-mail addresses and phone numbers with contact cards. This is not an amtomated solution, but I hope it can help and guide users at least. This PR is opened as suggestion of an approach and does not mean to be a finalized something. I'm open to any idea 😸

Proposed changes

  • Create a new page "Potential contact data"
  • Add a link to it next to the title of contact list with 💡 icon
  • In "Potential contact data": List embedded E-mail addresses and phone numbers per page/event/location *1
  • In "Potential contact data": List related contacts (either E-mail or phone number matched) too as suggestion

*1: not per translation, as the list would be then too long with a lot of duplicates. All E-mail addresses and phone numbers in all languages of the page/event/poi will be shown but without duplicate even if any of them appears multiple times in multiple of translations.

Note: I have decided to show targets (E-mail addresss, phone numbers) per content, not contents per target (where each E-mail address and phone number is used), because 1) users probably need context why and where those contact informations are given while replacing them with contact cards or creating a new contact and 2) the later view is almost the same with broken link list.

Side effects

Those points are still in progress and will be worked on, once this approach receives agreement from the team and we decide for details.

  • Naming, sentences, explanations and their translation, appearance, design etc.
  • Queries in the view
  • Preview of the page/event/location and/or link to their form (👁️ and ✏️ icons next to content title)
  • How to show suggested contact (maybe as contact card, or simply __str__ with link?)
  • Maybe: add a button for contact creation per ajax/pop-up under the suggested contact to create a new contact, so users can create a new one while seeing which E-mal address and phone numers are used for which topic.

Resolved issues

Fixes: #2957


Pull Request Review Guidelines

@MizukiTemma
Copy link
Member Author

@osmers
Currently it looks like this

Users are expected to click here
contact suggestion 1

No suggestion is shown if no contact targets are found
contact suggestion 2

If any detected, related contacts are shown
contact suggestion 3

@osmers
Copy link

osmers commented Jan 6, 2025

Users are expected to click here

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?
E.g. Vorschläge für Kontakte, die Sie erstellen können @nikolahoff maybe for a better phrasing that suggests to users that they can find suggestions on how to use the feature there

No suggestion is shown if no contact targets are found

Can you change it to Telefonnummer? :)

If any detected, related contacts are shown

So this only shows up with they already have a contact created, that uses the same information, right?
Is it feasible or even useful that maybe we show them lists of contact details that are in the content, but don't have a contact yet? Probably additionally to what you have already done here....

Edit: Maybe you are already planning the last point, not sure. Bcs that's what I understood from the description...

@JoeyStk JoeyStk self-assigned this Jan 6, 2025
@JoeyStk
Copy link
Contributor

JoeyStk commented Jan 6, 2025

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?

I agree with @osmers. I also only got it because of your explanation. My first suggestion to rephrase it would be simply:
"Analysis of content for existing contacts in" and for the German translation "Inhaltsanalyse für bestehende Kontaktdaten". What do you think about? :)

@JoeyStk
Copy link
Contributor

JoeyStk commented Jan 6, 2025

First of all thank you very much for this PR! It's a cool feature and a cool step forward! I'm truely grateful that you took on such a big task.

For now I only tested the usability of the feature and didn't have a look at the code yet. Here are a few things, that I noticed, that didn't make sense to me (yet).

  1. I'm a bit unsure how to interpret the icons
    grafik. To me they weren't clickable. I would have expected that the eye would take me to page/event/poi that contains the found contact. For the pencil I would have expected that it takes me to an editing page of some sort. What was your intention on adding the icons? :)

  2. When I copied the source code of this page (test cms, app), I got the following result in the contact detection. grafik To be honest, as a user I'm not totally sure what to do with this information next. Maybe we can think of something to guide the user more towards a goal?

  3. Maybe this goes to far and is not yet part of this PR or of the tool altogether, but when I copied the source code of this page (app), I expected for the tool to find the keyword "Kontakt" and maybe extract some kind of information for a contact from it

  4. This goes back a little bit to 2). I think I would have expected a button or something to convert the found phone number or email to a contact, if there is no contact found which already contains this information. A wonderful bonus addition would be, if on click on the button the information already gets transferred to the form and would be filled out already.

These are my thoughts on this feature for now :) I hope they are helpful in some form or another :)

@osmers
Copy link

osmers commented Jan 7, 2025

4. This goes back a little bit to 2). I think I would have expected a button or something to convert the found phone number or email to a contact, if there is no contact found which already contains this information. A wonderful bonus addition would be, if on click on the button the information already gets transferred to the form and would be filled out already.

Yeah, this is what I meant with my last point as well :) would make a lot of sense to make creating new contacts much easier and faster.

@MizukiTemma MizukiTemma added the deadline Needs to be fixed in the given time label Jan 7, 2025
@MizukiTemma
Copy link
Member Author

No suggestion is shown if no contact targets are found

Can you change it to Telefonnummer? :)

Done, thank you @JoeyStk

@MizukiTemma
Copy link
Member Author

Users are expected to click here

I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?

I agree with @osmers. I also only got it because of your explanation. My first suggestion to rephrase it would be simply: "Analysis of content for existing contacts in" and for the German translation "Inhaltsanalyse für bestehende Kontaktdaten". What do you think about? :)

Applied :)

@MizukiTemma MizukiTemma force-pushed the contact_from_existing_data branch from 10797b0 to 9422c60 Compare January 7, 2025 14:07
@MizukiTemma
Copy link
Member Author

@JoeyStk
Thank you for your review 👍

  1. Icon
    Planned are preview at 👁️ and a link to the page/event/location edit form at ✏️. The later is added now. As our preview functionality is currently only avaialble for pages, it is not yet implemente in this PR. If this idea gets confirmed, the preview function must be first extended for event and page, then added to the icon.

@MizukiTemma
Copy link
Member Author

MizukiTemma commented Jan 7, 2025

@JoeyStk
2. User navigation
Alternatively to the icon ✏️ next to the content title, we can add here a button "Go to page/event/location" which brings users to the edit form of the content.
And/or another button to create a new contact per ajax? (for this we will need first #3196 )

  1. Search per keyword
    I considered the same first and found some difficulty/complexity:
  • Words that can be a keyword are probably used in a totally different context too. For example, "Kontakt" in "Kontakt mit Krankheitserregern". It can result in too much false positiv.
  • Keywords are not limited. "Ansprechpartner" sounds very good as keyword, but contact person may be mentioned as "Berater:in" or "XYZ is zuständig" or "Hier können Sie sich wenden" too. We cannot search for every expression.
  • Keywords are translated in other languages. We could search for "Ansprechpartner", but how is this single word translated in other languages? if we only search for "Ansprechpartner" in german translations, we miss such case that different contact informations are given depend on the language.

If we ignore edge cases and go without precision, the search can be extended.

  1. Automatic contact generation
    I dreamed of this 😓
    Automatic creation is not possible, as every contact requires a POI.

if on click on the button the information already gets transferred to the form and would be filled out already.

Do you mean putting detected phone number and E-mail address into a contact form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create contacts from existing information
3 participants