-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest users potential contact sources #3314
base: develop
Are you sure you want to change the base?
Conversation
@osmers Users are expected to click here |
I would not have guessed that :D somehow the sentence leads me to believe that there is an information page (e.g. from the wiki) behind it, that explains, where I can use contacts) - maybe we can rephrase it?
Can you change it to Telefonnummer? :)
So this only shows up with they already have a contact created, that uses the same information, right? Edit: Maybe you are already planning the last point, not sure. Bcs that's what I understood from the description... |
I agree with @osmers. I also only got it because of your explanation. My first suggestion to rephrase it would be simply: |
First of all thank you very much for this PR! It's a cool feature and a cool step forward! I'm truely grateful that you took on such a big task. For now I only tested the usability of the feature and didn't have a look at the code yet. Here are a few things, that I noticed, that didn't make sense to me (yet).
These are my thoughts on this feature for now :) I hope they are helpful in some form or another :) |
Yeah, this is what I meant with my last point as well :) would make a lot of sense to make creating new contacts much easier and faster. |
Done, thank you @JoeyStk |
Applied :) |
Co-authored-by: JoeyStk <72705147+JoeyStk@users.noreply.github.com>
10797b0
to
9422c60
Compare
@JoeyStk
|
@JoeyStk
If we ignore edge cases and go without precision, the search can be extended.
Do you mean putting detected phone number and E-mail address into a contact form? |
Short description
This PR introduces a hint page to help users to create new contacts and replace embedded E-mail addresses and phone numbers with contact cards. This is not an amtomated solution, but I hope it can help and guide users at least. This PR is opened as suggestion of an approach and does not mean to be a finalized something. I'm open to any idea 😸
Proposed changes
*1: not per translation, as the list would be then too long with a lot of duplicates. All E-mail addresses and phone numbers in all languages of the page/event/poi will be shown but without duplicate even if any of them appears multiple times in multiple of translations.
Note: I have decided to show targets (E-mail addresss, phone numbers) per content, not contents per target (where each E-mail address and phone number is used), because 1) users probably need context why and where those contact informations are given while replacing them with contact cards or creating a new contact and 2) the later view is almost the same with broken link list.
Side effects
Those points are still in progress and will be worked on, once this approach receives agreement from the team and we decide for details.
__str__
with link?)Resolved issues
Fixes: #2957
Pull Request Review Guidelines