Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace black and pylint with ruff #3333

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Replace black and pylint with ruff #3333

wants to merge 23 commits into from

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Jan 14, 2025 •
edited
Loading

Short description

I am SO sorry, dear reviewers 🙈
@cclauss do you have an opinion on this? 😄

Proposed changes

  • black -> ruff
  • pylint -> ruff

Side effects

  • hahahaha
  • 👀

Resolved issues

Fixes: #3234

Pull Request Review Guidelines

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 3 times, most recently from 8a99cf6 to 89ef879 Compare January 14, 2025 09:29
@PeterNerlich PeterNerlich self-assigned this Jan 14, 2025
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from f914042 to 280f4a6 Compare January 15, 2025 08:59
@charludo charludo marked this pull request as ready for review January 15, 2025 10:57
@charludo
Copy link
Contributor Author

I've marked this as "ready for review". Due to the nature of the PR, this will constantly get merge conflicts, but luckily, 95% of the changes are "automatic" ones from ruff, so please feel free to review even if a merge conflict exists, I'll try to keep up with resolving them.

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 280f4a6 to c33177f Compare January 17, 2025 10:38
cclauss
cclauss reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% ruff format

Would reformat: integreat_cms/integreat_celery/celery.py
Would reformat: tests/cms/views/contacts/test_contact_actions.py

.pre-commit-config.yaml Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/code-style.rst Outdated Show resolved Hide resolved
docs/src/code-style.rst Show resolved Hide resolved
docs/src/tools.rst Outdated Show resolved Hide resolved
integreat_cms/README.md Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor

cclauss commented Jan 17, 2025

LGTM!

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from bc77cd4 to 20bd98f Compare January 17, 2025 17:20
PeterNerlich
PeterNerlich requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@PeterNerlich PeterNerlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Could it be finally happening??

The only conversation warranting a Request changes is that on integreat_cms/core/apps.py for me, the rest is peanuts

integreat_cms/cms/utils/file_utils.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
integreat_cms/core/apps.py Show resolved Hide resolved
integreat_cms/summ_ai_api/summ_ai_api_client.py Outdated Show resolved Hide resolved
integreat_cms/textlab_api/textlab_api_client.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
integreat_cms/api/v3/chat/utils/zammad_api.py Show resolved Hide resolved
integreat_cms/cms/views/dashboard/dashboard_view.py Outdated Show resolved Hide resolved
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from 7bd5aa6 to ec87e9e Compare January 22, 2025 12:37
@charludo charludo requested a review from PeterNerlich January 22, 2025 12:37
PeterNerlich
PeterNerlich approved these changes Jan 22, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JoeyStk JoeyStk added the not-testable Issues that are not testable label Jan 22, 2025
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from 01e0245 to 2ae3881 Compare January 24, 2025 08:18
charludo and others added 18 commits January 31, 2025 09:58
@charludo
Undo formatting changes to devtools
d021ac8
@charludo
change order of ruff check/format
6369e55
@charludo
remove unused imports
fc22d01
@charludo @cclauss
Update README.md
7147774 
Co-authored-by: Christian Clauss <cclauss@me.com>
@charludo @cclauss
Update docs/src/code-style.rst
5a158da 
Co-authored-by: Christian Clauss <cclauss@me.com>
@charludo @cclauss
Update docs/src/tools.rst
fa69f1d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@charludo @cclauss
Update integreat_cms/README.md
9011da4 
Co-authored-by: Christian Clauss <cclauss@me.com>
@charludo
version updates
2c2e658
@charludo
fix merge conflict
a6b8495
@charludo @PeterNerlich
Update integreat_cms/cms/utils/file_utils.py
32de807 
Co-authored-by: Peter Nerlich <PeterNerlich@users.noreply.github.com>
@charludo @PeterNerlich
Update README.md
4db2b40 
Co-authored-by: Peter Nerlich <PeterNerlich@users.noreply.github.com>
@charludo @PeterNerlich
Update pyproject.toml
5e31f00 
Co-authored-by: Peter Nerlich <PeterNerlich@users.noreply.github.com>
@charludo
fix ruff complaints after rebase
457edf3
@charludo
fix @PeterNerlich's non-auto-appliable suggestions
9610aef
@charludo @PeterNerlich
Update pyproject.toml
c1b5c50 
Co-authored-by: Peter Nerlich <PeterNerlich@users.noreply.github.com>
@charludo @PeterNerlich
Update README.md
d9dd849 
Co-authored-by: Peter Nerlich <PeterNerlich@users.noreply.github.com>
@charludo
fix ruff complaints after rebase
01da3b6
@charludo
fix ruff complaints after rebase
d0b6405
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 2ae3881 to d0b6405 Compare January 31, 2025 09:02
cclauss
cclauss reviewed Jan 31, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@charludo @cclauss
Update pyproject.toml
7b92121 
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterNerlich PeterNerlich PeterNerlich approved these changes

@cclauss cclauss cclauss left review comments

@JoeyStk JoeyStk Awaiting requested review from JoeyStk

@MizukiTemma MizukiTemma Awaiting requested review from MizukiTemma

@jonbulz jonbulz Awaiting requested review from jonbulz

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

At least 2 approving reviews are required to merge this pull request.

Assignees

@PeterNerlich PeterNerlich

Labels
not-testable Issues that are not testable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to ruff from pylint & black
4 participants
@charludo @cclauss @PeterNerlich @JoeyStk