-
Notifications
You must be signed in to change notification settings - Fork 2
1.8.7 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1.8.7 #235
Conversation
📝 WalkthroughWalkthroughBumps release/version strings to v1.8.7 across build and packaging configs; adds Dagster pipelines and jobs for series and sets with discord sensors; enhances discord sensor exception handling; adds text-search UI to card list with tests; refines move flavor-text selection and includes new test golden data. Changes
Sequence Diagram(s)mermaid Scheduler->>SeriesJob: trigger schedule/asset job Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@card_data/pipelines/definitions.py`:
- Around line 48-52: The defs_series dg.Definitions currently includes
discord_success_sensor and discord_failure_sensor which can cause duplicate-name
errors when multiple defs are merged; remove these sensors from defs_series
(leave only assets, jobs, and any unique sensors) and place the
discord_success_sensor and discord_failure_sensor in a single shared
dg.Definitions (or the one canonical defs) so they are defined exactly once
across the repo; update any other dg.Definitions that previously included those
same sensor symbols to reference the shared defs instead to prevent
DagsterInvalidDefinitionError.
In `@card_data/pipelines/sensors.py`:
- Around line 21-24: The except clauses are ordered incorrectly: the broad
"except Exception as e" currently precedes the specific "except
requests.RequestException as e" so the latter is unreachable; swap the order so
"except requests.RequestException as e" comes before "except Exception as e" in
the notification-sending error handling, and make the same change at the second
occurrence (the other try/except that uses the same two handlers) so
RequestException is handled by its specific branch first.
In `@cmd/move/move.go`:
- Around line 19-23: The package-level variables sv and swsh cause state leakage
between invocations of moveEffectContainer; remove the top-level declarations of
sv and swsh and instead declare them as local variables inside
moveEffectContainer so each call gets fresh state. Edit moveEffectContainer to
add local declarations for sv and swsh at the start of the function, update any
uses inside that function to reference the new locals, and delete the original
package-level sv and swsh declarations.
Summary by CodeRabbit
New Features
Improvements
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.