Mention direnv allow in Contributing guide
#1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Jul 16, 2023
CONTRIBUTING.md
Outdated
| @@ -28,6 +28,7 @@ Clone the IHP repository into the project directory. The `IHP` directory is adde | |||
| git clone git@github.com:digitallyinduced/ihp.git IHP | |||
| # only needs to be run once (do not run inside the IHP directory) | |||
| make -B build/ihp-lib | |||
There was a problem hiding this comment.
The direnv allow needs to happen before the make -B build/ihp-lib
There was a problem hiding this comment.
I think it worked for me also after, but sure - I'll change to be on the safe side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1747 (comment)