Update testing.markdown - workaround GH Runner disk space issue #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I suggest we link to https://github.com/digitallyinduced/ihp-boilerplate/blob/master/.github/workflows/test.yml so we won't have to maintain the same code in two places. |
mpscholten
approved these changes
Aug 6, 2024
|
@mpscholten seems like tests are failing. Do you happen to know know why? |
|
I've moved the hsx tests to the ihp-hsx package (previously the were part of the ihp package), but forgot to remove them from the |
|
Fixed via 5630059 |
|
Thanks |
|
I still have one concern: before you fixed it, the test on
Maybe tests are not running as they should on |
|
Good point. I've changed the github configuration via 6bba479 this likely fixes that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.