Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support maps in Stringify #752

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Support maps in Stringify #752

merged 1 commit into from
Nov 6, 2024

Conversation

andrewsomething
Copy link
Member

Reviewing #749, I noticed that the Stringify utility does not handle maps well. For example, the test output before this change would be something like:

map[1:0xc00007a340 2:0xc00007a360 3:0xc00007a380]

Now it is:

map[1:godo.DropletBackupPolicy{DropletID:1, BackupEnabled:true}, 2:godo.DropletBackupPolicy{DropletID:2, BackupEnabled:false}, 3:godo.DropletBackupPolicy{DropletID:3, BackupEnabled:true}]

@andrewsomething andrewsomething requested a review from a team November 6, 2024 15:11
bentranter
bentranter approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsomething andrewsomething merged commit d489279 into main Nov 6, 2024
8 checks passed
@andrewsomething andrewsomething deleted the asb/map-stringify branch November 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsomething @bentranter